fix: undo counted changes in one step#39
Merged
Conversation
oribarilan
reviewed
Jun 14, 2026
oribarilan
reviewed
Jun 14, 2026
Owner
|
awesome stuff!! thanks |
hamidi-dev
force-pushed
the
fix/counted-change-undo
branch
from
92e174b to
35a2e3b
Compare
Contributor
Author
|
all done :-) |
oribarilan
added a commit
that referenced
this pull request
Jun 17, 2026
The comment in `applyActions` still described the old single-snapshot logic after #39 changed it to a batch-flag mechanism. Updated to reflect how `keepUndoSnapshotForBatch` actually works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes undo behavior for counted changes like
3dw.Details
Previously, counted destructive motions could require multiple
upresses because each repeated command became its own editor undo step. This adds a single pre-change snapshot for counted delete/change operations so oneurestores the full buffer state.Covered cases include:
3dw2cw3dd